shopping list app completed #7
Conversation
|
Ravi, Here's some impressions after reviewing your submission. I was able to get the application up and running easily. I was able to add a list, and add items to it. However, what we'd really like to see for the add item portion is separate form fields for an items name, price, and SKU. Also, in looking at the code I noticed your components are named Lane and Note from the original example. For the code to be easily readable by other developers, we'd love to see you rename these components to be more specific to the application your are a building (ShoppingList and Item for example). If you'd like to make more changes and have me review again, I'd be happy to do that. At this point we've selected a few candidates for interviews, and based on the outcome of these we may or may not do more interviews for the initial pair of apprentices. However, we still hope to hire a second pair of apprentices in a month or two and would be happy to consider your submission for this second pair. |
|
Hi Chris, I would definitely like to resubmit. I’ll fix up the item portion to have separate fields. About the components, I initially changed the names for “notes/note” but then realized they made more sense to me in terms of a note because a shopping list is a note that I’m making and the shopping list will have items. I initially called them lists and on the lists would be shopping list of “products” but then that didn’t make sense to me. Any who I’ll check out what would be appropriate and fix it. I’m thinking of just re-doing the tutorial again because a lot of it didn’t make sense to me. I scanned the internet for other tutorials and explanations but they seemed to be a little dated and used the ES5 syntax which confused me a little bit. I’ll happily resubmit for another opportunity in the second round of apprentices. Thank you for your feedback! Sincerely, Ravi
Ravi Patel |
completed app